BHoM / BHoM/LadybugTools_Toolkit

Setting ylim for utci_day_comfort_metrics plot causes odd overlaps between secondary axes

Open
#160 0 comments 0 reactions 1 assignee Claimed by @JohannaOlin1 View on GitHub
type:bug
Dominant language
Python
Stars
3
Forks
2
Avg merge
8d 20h
Merged PRs (30d)
2

Description

#### Description:

In order to set ylims for the `utci_day_comfort_metrics` plot type (usually accessed via the ExternalComfort object), the axes added to this figure would need to each be individually access in order to modify these properties. In doing so, the plot getas a bit messed up and doesn't look as nice.

Merely exposing the ylims and variable-specific axes for this output would make it possible to fix the limits and ensure the plot gets generated correctly - without the need to hack apart something which mostly works.

The method can be found here:
https://github.com/BHoM/LadybugTools_Toolkit/blob/599970877455b36941398bdea8b2570c64c21276/LadybugTools_Engine/Python/src/ladybugtools_toolkit/plot/_utci.py#L143

#### Steps to reproduce:

Here is some code which does what we're trying to do ... but poorly
```python
fig, ax = plt.subplots(1, 1, figsize=(10, 5))
ec.plot_utci_day_comfort_metrics(ax=ax, month=3, day=21)

_utci_ax, _dbt_ax, _mrt_ax, _rh_ax, _ws_ax = fig.get_children()[-5:]

_utci_ax.set_ylim(0, 40)
_dbt_ax.set_ylim(0, 50)
_mrt_ax.set_ylim(0, 100)
_ws_ax.set_ylim(0, 15)
_rh_ax.set_ylim(0, 100)
```
And this is what it generated, with the dodgy additional axes:
![image](https://github.com/BHoM/LadybugTools_Toolkit/assets/10939984/bf6cbd9b-222f-4111-a219-19449ee3600f)

#### Expected behaviour:

`ylims` as additional args/kwargs to the plot method, also accessible from the ExternalComfort object which calls it.

#### Test file(s):

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.