BHoM / BHoM/File_Toolkit

File_Adapter: refactoring-refactor to match ReplaceInMemory refactoring

Open
#149 0 comments 0 reactions 1 assignee Claimed by @alelom View on GitHub
type:compliance
Dominant language
C#
Stars
0
Forks
7
PR merge metrics
No merged PRs in 30d

Description

### Description
As explained in https://github.com/BHoM/BHoM_Adapter/issues/106

Since File_Adapter does not set `AdapterConfig.ProcessInMemory`, that defaults to true.
This means that the call to Create will always have `replaceAll` set to true.

Therefore the following calls will have `replaceAll` always set to true:
https://github.com/BHoM/BHoM_Adapter/blob/49d63e82db3eefa5eecb960e1bd84ab410fc2c51/File_Adapter/CRUD/Create.cs#L40-L46

So these lines never get called
https://github.com/BHoM/BHoM_Adapter/blob/49d63e82db3eefa5eecb960e1bd84ab410fc2c51/File_Adapter/CRUD/Create.cs#L80-L81
As well as this is never called with Append:
https://github.com/BHoM/BHoM_Adapter/blob/49d63e82db3eefa5eecb960e1bd84ab410fc2c51/File_Adapter/CRUD/Create.cs#L57

### Proposed change
If anything, the option for the Create method to override should be specifiable dynamically, rather than hard-coded.
This might be solved by making the so called `config` parameter available to all CRUD methods.

I would remove `replaceAll` as a parameter of the Create() and use another parameter like
`config["CreateOverride"] = true`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.