BHoM / BHoM/BHoM_Engine

Geometry_Engine: CollapseToPolyline issues

Open
#869 6 comments 0 reactions 1 assignee Assigned to @IsakNaslundBh View on GitHub
severity:medium type:bug
Dominant language
C#
Stars
30
Forks
13
Avg merge
7d 10h
Merged PRs (30d)
5

Description

Two issues found for the CollapseToPolyline method regarding the maxSegmentCount:

1. The method uses the maxSegmentCount for each subcurve of a polycurve, not enveloped for the curve as a whole, resulting in maxSegmentCount * nbCurvesInPolycurve number of segements. See example bellow where a polycurve made up of two curves is used:

![image](https://user-images.githubusercontent.com/22005920/54353366-1e3ca980-4654-11e9-99c0-27d3754fde09.png)

2. For arcs, the method always returns at least 2 segments, even if maxSegementCount is set to 1. Think that `if(maxSegementCount <2)` we should just return one segement between the start and endpoints:

![image](https://user-images.githubusercontent.com/22005920/54353451-652a9f00-4654-11e9-9f71-78e78bd7217a.png)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.