BHoM / BHoM/BHoM_Engine

Geometry_Engine: TransformMatrix created from quaternion is not matching Rhino's version

Open
#463 1 comment 0 reactions 0 assignees View on GitHub
severity:medium type:bug
Dominant language
C#
Stars
30
Forks
13
Avg merge
7d 10h
Merged PRs (30d)
5

Description

Unit test [here]()

Methods failing due to other issues:

All of them, due to https://github.com/BuroHappoldEngineering/Grasshopper_Toolkit/issues/221
Notes: The methods are not really failing but due to the issue above, I was not able to fill the Verify cluster

Edit after https://github.com/BuroHappoldEngineering/Grasshopper_Toolkit/pull/229:

Methods failing in the test itself:

RotationMatrix
Methods failing due to a possible wrong test method:

TransformMatrix(Quaternion q) - I don't knot the theory behind this, so I cannot check if the correspondent rhino method is affine

Contributor guide

Open the contributing guide

Research direction

Start with the unit test linked in the issue, although its URL is empty, and review issue #221 for the blocking Verify-cluster problem. Compare the RotationMatrix failure and TransformMatrix(Quaternion q) behavior against Rhino's corresponding methods, including whether the Rhino result is affine. Done means the test has a confirmed expected result and the affected methods pass it.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
computer-graphics
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.