BHoM / BHoM/BHoM_Engine

Geometry_Engine: HashArray does not work for PlanarSurface (and most likely other types)

Open
#3,540 0 comments 0 reactions 1 assignee Claimed by @alelom View on GitHub
type:bug
Dominant language
C#
Stars
30
Forks
13
Avg merge
7d 10h
Merged PRs (30d)
5

Description

#### Description:

The reason for observed behaviour is the fact that in the lines below an overload of `HashArray` taking `ICurve` is called, which attempts to call other overloads with `skipEndPoint` argument downstream (second snippet). That throws an exception for the simple reason that most overloads do not have the parameter mentioned.

As far as I understand, the solution for that bug should be cleaning up `skipEndPoint` for all `HashArray` overloads taking sub-classes of `ICurve` - either implement it properly or just remove if not needed.

https://github.com/BHoM/BHoM_Engine/blob/723a03f908bead0d8acdca9b04f2a6294aa05aba/Geometry_Engine/Query/HashArray.cs#L307-L313

https://github.com/BHoM/BHoM_Engine/blob/723a03f908bead0d8acdca9b04f2a6294aa05aba/Geometry_Engine/Query/HashArray.cs#L115-L132

#### Test file(s):

On [SharePoint](https://burohappold.sharepoint.com/sites/BHoM/02_Current/Forms/AllItems.aspx?id=%2Fsites%2FBHoM%2F02%5FCurrent%2F12%5FScripts%2F01%5FIssue%2FBHoM%2FBHoM%5FEngine%2FGeometry%5FEngine%2F%233540%2DHashArrayBug&viewid=a5a93cba%2Dfcca%2D46cc%2Da31a%2D80b8d5cbfd7b&FolderCTID=0x0120008122C8891F89054B8ACED0196C70DFC4)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.