BHoM / BHoM/BHoM_Engine

Serialiser_Engine: Investigate edge case where the Serialiser_Engine is able to deserialise methods with changed method signature

Open
#3,310 0 comments 0 reactions 1 assignee Assigned to @IsakNaslundBh View on GitHub
type:bug
Dominant language
C#
Stars
30
Forks
13
Avg merge
7d 10h
Merged PRs (30d)
5

Description

#### Description:

https://github.com/BHoM/BHoM_Engine/pull/3309/files shows that the Serialiser_Engien is able to deserialise and implicitly upgrade the methods even if it has a changed method signature. For the particular case, it upgrades correctly, but for the general case this could be an issue if it upgrades to something it is not meant to upgrade to. All changes to method signature should be handled explicitly in versioning and this type of upgrade by chance should not really be happening.

For the current case it might have to do with input type being changed between "Timber" and "ITimber", and the fact that we sometimes remove the leading I in the ToText method for types, but is to be investigated.

#### Steps to reproduce:

#### Expected behaviour:

#### Test file(s):

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.