BHoM / BHoM/BHoM_Engine

Geometry_Engine: SortAlongCurve (probably) should not cull the points that do not lie on the curve

Open
#3,108 0 comments 1 reaction 0 assignees View on GitHub
type:feature
Dominant language
C#
Stars
30
Forks
13
Avg merge
7d 10h
Merged PRs (30d)
5

Description

#### Description:

Currently `SortAlongCurve` method silently culls all points that do not lie on it, which is potentially dangerous and different from what such methods usually do in other geometry engines - the common approach is to sort the input points based on their correspondent closest points on the curve. Briefly discussed with @peterjamesnugent #3107 starting from [this comment](https://github.com/BHoM/BHoM_Engine/pull/3107#pullrequestreview-1533083334).

**Warning:** if the decision is made to stop culling the points, let's be careful because it is a breaking change and can affect the existing workflows.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.