Diffing_Engine: `Query.CombinedDiff()` shorten lines and consistent null check for `ModifiedObjectDiffernces`
Open
type:bug
- Dominant language
- C#
- Stars
- 30
- Forks
- 13
- Avg merge
- 7d 10h
- Merged PRs (30d)
- 5
Description
Discovered as part of an issue in another tool. It seems this method can possibly return `null` for `ModifiedObjectDifffernce.` It is difficult to understand what is going on in this method due to the ternaries, and it appears to have multiple checks for null: `!= null`, `??`, etc.
https://github.com/BHoM/BHoM_Engine/blob/ef5dcef925d7de33ddfe976d69b139ae20f79f5c/Diffing_Engine/Query/CombinedDiff.cs#L54-L63
Contributor guide
Assessment
This issue has not been assessed yet.