BHoM / BHoM/BHoM_Engine

Architecture_Engine : Grids - curves should not be projected

Open
#265 1 comment 0 reactions 2 assignees Assigned to @rwemay View on GitHub
severity:medium type:bug
Dominant language
C#
Stars
30
Forks
13
Avg merge
7d 10h
Merged PRs (30d)
5

Description

The grid constructor currently projects all ICurves to Plane.XY. Some of these curve projections aren't implemented (hence some pull functions not working at the moment). Projecting curves to an empty XY plane will have unintended consequences for a user (for example, primitive geometry will become complex and no longer able to parameterise). Project to plan should either be removed altogether, or curves planes tested to see if they are parallel to XY then translating (not projecting). Any curves not parallel to XY will be rejected, but since every use-case of an architectural grid should be XY, there should be very few exceptions raised.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.