BHoM / BHoM/BHoM_Engine

Humans_Engine: Geometry of view cones + spectator head should not be hardcoded.

Open
#2,440 3 comments 0 reactions 1 assignee Claimed by @rolyhudson View on GitHub
type:compliance
Dominant language
C#
Stars
30
Forks
13
Avg merge
7d 10h
Merged PRs (30d)
5

Description

#### Broken rules:
Currently view cones used for Avalue analysis and the spectator's head outline are hard coded in `Create` methods for the `ViewCone` and `Spectator`.

All are 2d Polylines the X and Y coordinates exist as arrays within the code. These should be externalised for transparency / traceability as part of the Quality Assurance in view quality analysis.

#### Suggestions to restore compliance:
These objects should either be placed as objects in a Dataset or created from input parameters.

Dataset option is complicated for the following reasons:
- The Source for each object is different and so each would require an individual Dataset (one Source per Dataset is the current limitation)
- Datasets currently only accept `IBHoMObjects` and the objects in questions are most easily represented as Polylines, collections of Points or numeric collections each would require wrapping.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.