BHoM / BHoM/BHoM_Engine

Analytical_Engine: Subgraphs method fails for directed graphs

Open
#2,271 0 comments 0 reactions 1 assignee Claimed by @rolyhudson View on GitHub
type:bug
Dominant language
C#
Stars
30
Forks
13
Avg merge
7d 10h
Merged PRs (30d)
5

Description

#### Description:
Due to the way the traversal method starts from randomly selected entities it is possible that a directed graph cannot be traversed.
Currently the method will store the traversed parts as a sub graph.
For example this should return a single graph.
![Screenshot 2021-01-20 170604](https://user-images.githubusercontent.com/6618854/105209544-dcc79000-5b41-11eb-9fd5-3ce516758172.jpg)

#### Steps to reproduce:
Use the test file - it may ne necessary to recompute the definition to see the error as the process randomly selects a start entity from which traversal initiates.

#### Expected behaviour:
A single graph should be the result

#### Test file(s):
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/01_Issue/BHoM/BHoM_Engine/Analytical_Engine/%232271_subgraphtest.gh?csf=1&web=1&e=FaZ0K6

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.