BHoM / BHoM/BHoM_Engine

Geometry_Engine: provide handling of null inputs

Open
#1,923 0 comments 0 reactions 0 assignees View on GitHub
type:compliance
Dominant language
C#
Stars
30
Forks
13
Avg merge
7d 10h
Merged PRs (30d)
5

Description

#### Broken rules:

Follow up to #1913 - starts from [that comment](https://github.com/BHoM/BHoM_Engine/pull/1913#pullrequestreview-461493946)
Having resolved `NotImplementedException`s next step should be to handle null inputs at interfaces. At this moment if any interface gets a null input it won't pass it to any method and throw an misleading ambiguous call exception instead.

#### Suggestions to restore compliance:

- Change fallback methods input type to `object` to catch dynamically resolved `null`s - [turned out](https://github.com/BHoM/BHoM_Engine/pull/1913#issuecomment-670428183) that dynamic interfaces will not pass `null`s.
- Add NullCheck method to the interfaces and/or create another type of fallback method.

Contributor guide

Open the contributing guide

Research direction

Start by reading issue #1913 and the linked pull-request review and comment, then trace the Geometry_Engine interfaces and their fallback methods. Determine how null inputs currently produce the ambiguous call exception; done means null inputs are handled at the interfaces without that misleading exception.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.