BHoM / BHoM/BHoM_Engine

Geometry_Engine: Method correcting Arcs

Open
#1,241 6 comments 0 reactions 1 assignee Claimed by @LMarkowski View on GitHub
type:feature type:question
Dominant language
C#
Stars
30
Forks
13
Avg merge
7d 10h
Merged PRs (30d)
5

Description

#### Description:

Some Arcs from Rhino have switched angles. E.g Instead of having StartAngle = 0 and EndAngle = 1 they have StartAngle = -1 and EndAngle = 0. Is it justified by anything?
Some of my methods base on that an arc has a StartAngle = 0 so I just wrote simple check correcting it:
`if(arc.StartAngle != 0)`
`{`
`arc.CoordinateSystem = arc.CoordinateSystem.Rotate(arc.CoordinateSystem.Origin, arc.CoordinateSystem.Z, arc.StartAngle);`
`arc.EndAngle = -arc.StartAngle;`
`arc.StartAngle = 0;`
`}`

It works like this:
![image](https://user-images.githubusercontent.com/48125514/66128740-c6b15b80-e5ee-11e9-870f-ab780d370739.png)
Geometrically those two arcs are identical.
Do you think it is worth adding to the engine?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.