BHoM / BHoM/BHoM_Adapter

BHoM_Adapter: UpdateProperty - return consistency with other methods

Open
#135 1 comment 0 reactions 1 assignee Claimed by @alelom View on GitHub
severity:low type:compliance
Dominant language
C#
Stars
7
Forks
5
PR merge metrics
No merged PRs in 30d

Description

See also https://github.com/BHoM/BHoM_Adapter/issues/135

#### Broken rules:
The UpdateProperty interface returns the number of objects updated, while the Push returns the list of objects pushed (and therefore potentially updated). I am not sure this logic makes sense other than "We coded what we needed to get what we wanted" kind of way.

It's possible that the UpdateProperty return type has not changed since the Push was returning a boolean, as it has not been in use that much at all.

#### Suggested changes to restore compliance:
Change the return type of the UpdateProperty to return the List of objects with the updated properties.

## Additional note
Note that UpdateProperty is implemented only in 3 Toolkits, so we can postpone this as explained also in my comment below.
![image](https://user-images.githubusercontent.com/6352844/67501888-f1865100-f67c-11e9-9b4b-a0988f4e8b3e.png)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.