BCStudentSoftwareDevTeam / BCStudentSoftwareDevTeam/lsf

Problems with Secondary overload behavior

Open
#559 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
1
Forks
1
PR merge metrics
No merged PRs in 30d

Description

There are a couple of issues around our overload handling for secondaries.

- Secondaries that trigger an overload are stored as one `FormHistory` record, with the type `Labor Overload Form`. This means they don't show up in Labor History, which only looks for 'base' `FormHistory` entries so that it can group the additional forms together. I suspect this causes other problems as well.
- When the primary Labor Status Form is modified (or adjusted, probably) to fewer hours, removing the overload condition, we don't change the secondary away from an overload form, and we can't delete the overload's FormHistory record like we do for Primaries, because there is only one record for secondaries (see above)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.