BCStudentSoftwareDevTeam / BCStudentSoftwareDevTeam/lsf
Remove unused function calls from pending forms page
- Dominant language
- Python
- Stars
- 1
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
We are making javascript function calls on the pending forms page to nonexistent functions. They are mostly not throwing errors, but there isn't a reason for them to exist. Review the Javascript and get rid of old or nonexistent functions.
Example in `app/static/js/allPendingForms.js`:
```
151 // Try and catch is used here to prevent General Search page from reloading the entire the page.
152 try {
153 runformSearchQuery();
154 $('#approvalModal').modal('hide');
155 }
156 catch(e){
157 location.reload(true);
158 }
```
`runformSearchQuery` does not exist in the page.
Review to see if there are other things like this and decide if they need to be replaced with working functionality or if they can just be removed. Also look at surrounding code and clean up as necessary. In this example, we probably don't need a try/catch anymore, and we can just hide the approval modal.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.