BCStudentSoftwareDevTeam / BCStudentSoftwareDevTeam/lsf-oss

Local Login refactor

Open
#19 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
Python
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

Shibboleth and Local login are both working (mostly). But, code is everywhere.

Notes:
1. refactor to use a before_app_request decorator to load the current user, handling shib or local gracefully and not in the controllers
2. Remove logic from controllers for dealing with current user, since it'll be everywhere from 1.
3. Consider removing the login_manager or making it handle everything more gracefully as well.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.