BAndysc / BAndysc/WoWDatabaseEditor

[Bug] Insufficient WHERE part of DELETE query for phase_area conditions

Open
#152 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
C#
Stars
564
Forks
169
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
Currently only `SourceTypeOrReferenceId` and `SourceEntry` is used for the DELETE statement in `phase_area`. That results in ALL phase conditions related to a specific area/zone being deleted instead of only the relevant one.

**Version (commit hash)**
c107adef2d89db9669a0779ca250a15c64134165

**To Reproduce**
Steps to reproduce the behavior:
1. Open phase_area editor
2. Use area 7502
3. Add phase 7138
4. Add condition quest completed 44663
5. Generate SQL
6. Notice the DELETE statement only contains `SourceTypeOrReferenceId` and `SourceEntry`

**Expected behavior**
Generate DELETE statement based on `SourceTypeOrReferenceId`, `SourceEntry` AND `SourceGroup` AND `SourceId` (I assume its generated somewhere generic)

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in the phase_area editor's SQL generation path and reproduce the issue using area 7502, phase 7138, and quest condition 44663. Inspect where the DELETE statement is assembled and verify that the generated query distinguishes the relevant condition with SourceGroup and SourceId; done means unrelated phase conditions are preserved.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp, sql
Domain
database, desktop
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.