Azure / Azure/umock-c

Actual calls do not look nice

Open
#28 1 comment 0 reactions 0 assignees View on GitHub
enhancement up for grabs
Dominant language
C
Stars
36
Forks
27
Avg merge
32m
Merged PRs (30d)
3

Description

When using .ValidateArgumentBuffer(...) this is what is on the screen when it happen to fail validation:

```code
Expected: [bsdl_metadata_write_async(0000000000000001,[0x00 0x50 0x00 0x00 0x00 0x00 0x00 0x00 0x02 0x00 0x00 0x00 0x00 0x00 0x00 0x00],0000000000000000,0000000000000000)]

Actual: [bsdl_metadata_write_async(0000000000000001,000002630F9BFEB0,00007FF72BA8B980,000002630F9D3080)]
```

Note how the expected is nicely showing the buffer as an array, while the Actual call shows a pointer.

Proposal is to have Actual call show an array too, because that gives some insight of "what doesn't match".

Best Regards,
Andrei Porumb

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the implementation of ValidateArgumentBuffer and the code that formats the Expected and Actual calls. Compare how buffer arguments are rendered in each path; done means the Actual call shows the buffer contents as an array rather than only a pointer, with existing validation behavior preserved.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
testing
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.