Azure / Azure/typespec-azure

[resource-manager]: The `etag` properties in `@azure-tools/typespec-azure-resource-manager` should have the type of `ETag` from azure core

Open
#2,519 2 comments 0 reactions 0 assignees View on GitHub
breaking-change feature lib:azure-resource-manager
Dominant language
TypeScript
Stars
27
Forks
90
Avg merge
1d 22h
Merged PRs (30d)
156

Description

Now the `etag` properties are modeled as `string` - which is not entirely correct, we have the `ETag` scalar defined in `@azure-tools/typespec-azure-core` therefore we should use them.
For instance: https://github.com/Azure/typespec-azure/blob/13dd00287e232498d90234613396500d5a983db2/packages/typespec-azure-resource-manager/lib/models.tsp#L264

Contributor guide

Open the contributing guide

Research direction

Read packages/typespec-azure-resource-manager/lib/models.tsp at the referenced etag properties, then inspect the ETag scalar in @azure-tools/typespec-azure-core. Update the resource-manager etag properties to use ETag rather than string, and verify the affected TypeSpec models and generated output remain correct.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.