Azure / Azure/typespec-azure

[arm-common-types]: percentComplete should be double

Open
#2,041 4 comments 0 reactions 0 assignees View on GitHub
cli/psh feature lib:azure-resource-manager
Dominant language
TypeScript
Stars
27
Forks
90
Avg merge
1d 22h
Merged PRs (30d)
156

Description

### Service Team Contacts (Dev)

_No response_

### Choose which kind of change this is

Correction to Existing Type

### Describe the change, Provide the desired TypeSpec or json-schema for the change as appropriate.

In typespec-azure-resource-manager, the type of [percentComplete](https://github.com/Azure/typespec-azure/blob/main/packages/typespec-azure-resource-manager/lib/common-types/types.tsp#L205C3-L205C18) is float64. While in [common types](https://github.com/Azure/azure-rest-api-specs/blob/main/specification/common-types/resource-management/v5/types.json#L447-L452) in swagger repo, we do not specify `"format": "double"` for it.

### Link to documentation if available

_No response_

### Additional notes or questions

_No response_

### Checklist

- [x] Follow our [Code of Conduct](https://github.com/azure/typespec-azure/blob/main/CODE_OF_CONDUCT.md)
- [x] Change is approved by Arm API Review
- [x] Please update issue title and choose the change type.

Contributor guide

Open the contributing guide

Research direction

Start in packages/typespec-azure-resource-manager/lib/common-types/types.tsp at the percentComplete definition, then compare it with specification/common-types/resource-management/v5/types.json in the linked swagger repository. Update the TypeSpec definition so its generated representation specifies the same double format as the common types schema, and verify the two definitions align.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.