Azure / Azure/template-analyzer

If a Rule Engine fails, results from other engines should still be returned

Open
#192 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
143
Forks
47
PR merge metrics
No merged PRs in 30d

Description

In *TemplateAnalyzer.cs*, running both `JsonRuleEngine` and `PowerShellRuleEngine` are done within the same `try` block. If one of them throws an exception, a wrapper exception is then thrown, and potential results from another engine are lost.

If both are tried separately, the exceptions can be caught to process later. But there should be thought put into what to do with the exceptions, so results can be available **and** the exception can be surfaced to the user.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.