Azure / Azure/static-web-apps

Unable to overide PR environment with named environment

Open
#1,378 2 comments 5 reactions 0 assignees View on GitHub
enhancement
Dominant language
No language data
Stars
346
Forks
67
PR merge metrics
No merged PRs in 30d

Description

The workflow i want for deploying my static apps is this

- creating, pushing, or reopening a pr deploys to a static environment called 'staging'.

I need it as a static environment so i can add the redirect URL to my auth provider and add the app url to the CORS on my API etc. I have no use or need for PR numbered environments.

Its not clear to me how i achieve the above. If i run the github action 'like so in a pr
```
- name: Build And Deploy
id: builddeploy
uses: Azure/static-web-apps-deploy@v1
with:
azure_static_web_apps_api_token: ${{ secrets.AZURE_STATIC_WEB_APPS_API_TOKEN_JOLLY_FOREST_0E0A91310 }}
repo_token: ${{ secrets.GITHUB_TOKEN }} # Used for Github integrations (i.e. PR comments)
action: "upload"
app_location: "/"
api_location: ""
output_location: "dist"
deployment_environment: "staging"
```

PR changes do not deploy to the staging environment - they continue to depoly to a pr environment. It only seems to deploy to staging when the action 'close' is called. However this is only called when the PR is closed.

The behaviour i want and would expect is hard to achieve. I would expect a named deployment_environment setting to override the PR environments from being triggered at all.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.