Azure / Azure/static-web-apps-cli

Ship StaticSitesClient with swa-cli

Open
#631 6 comments 4 reactions 0 assignees View on GitHub
command: deploy priority: low (P2) scope: deploy-client type: enhancement version: ga
Dominant language
TypeScript
Stars
668
Forks
156
PR merge metrics
No merged PRs in 30d

Description

**Is your feature request related to a problem? Please describe.**

swa-cli currently downloads a binary called StaticSitesClient from the internet before it uses it to deploy to Azure SWA. This leads to different issues: #557 #594 #615

It is not a good idea to change the behavior of software with the same version.

It is also not a good practice to download and run random code on running an NPM program (it is OK when installing the program).

**Describe the solution you'd like**

Package the StaticSitesClient with the swa-cli.

**Describe alternatives you've considered**

You could also pin the version of StaticSitesClient in the swa-cli and download the binary on "npm install". This would at least solve the issue with the change of behavior.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.