Azure / Azure/sonic-sairedis.msft

PR 24 Autoresolved several commits that were already autoresolved in PR 14

Open
#31 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
0
Forks
25
Avg merge
1d 10h
Merged PRs (30d)
2

Description

PR 24 Autoresolved several commits that were already autoresolved in PR 14.

Comparing commit lists, it can been seen that several commits included in PR14 were rolled into PR 24 as well:
PR 14:
```
* 6b263b8e - (origin/202411) [FC] Support Policer Counter (#1533) (2025-02-19) [mssonicbld]
* e53489e5 - [syncd] Update log level for bulk api (#1532) (2025-02-18) [Jianyue Wu]
* 7ae00e53 - Define bulk chunk size and bulk chunk size per counter ID (#1528) (2025-02-11) [mssonicbld]
* f35e743a - [nvidia] Skip SAI discovery on ports (#1524) (2025-02-07) [mssonicbld]
* bf049ed2 - Use sonictest pool instead of sonic-common and fix arm64 issue. (#1516) (2025-02-05) [mssonicbld]
* ffe371d6 - [syncd] Support bulk set in INIT_VIEW mode (#1517) (2025-02-05) [mssonicbld]

```

PR 24:
```
* 8c17d4b6 - (origin/202411) Revert "Do not enter vendor SAI critical section for counter polling/clearing operations (#1450)" (#1541) (2025-02-27) [mssonicbld]
* 3df03e19 - Optimize counter polling interval by making it more accurate (#1457) (#1534) (2025-02-26) [Stephen Sun]
* d884ff9a - [syncd] Move logSet logGet under mutex to prevent race condition (#1520) (#1538) (2025-02-20) [Kamil Cudnik]
* ec8b3c30 - Fix pipeline errors related to rsyslogd and libswsscommon installation (#1535) (2025-02-19) [mssonicbld]
* 6b263b8e - [FC] Support Policer Counter (#1533) (2025-02-19) [mssonicbld]
* e53489e5 - [syncd] Update log level for bulk api (#1532) (2025-02-18) [Jianyue Wu]
* 7ae00e53 - Define bulk chunk size and bulk chunk size per counter ID (#1528) (2025-02-11) [mssonicbld]
* f35e743a - [nvidia] Skip SAI discovery on ports (#1524) (2025-02-07) [mssonicbld]
* bf049ed2 - Use sonictest pool instead of sonic-common and fix arm64 issue. (#1516) (2025-02-05) [mssonicbld]
* ffe371d6 - [syncd] Support bulk set in INIT_VIEW mode (#1517) (2025-02-05) [mssonicbld]

```

This results in at least one build breakage as a result of a duplicate check of `COUNT_TYPE_POLICER` in FlexCounter.cpp, wherein only 4 args are passed to `CounterContext` presuming the old constructor signature, which is no longer valid.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in FlexCounter.cpp and inspect the COUNT_TYPE_POLICER handling alongside the CounterContext constructor definition. Compare the duplicated logic from the merged commits, then build the affected component to confirm the duplicate check and outdated constructor call are resolved.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.