Azure / Azure/sonic-mgmt.msft

invalid macsec link metadata minigraph xml generation

Open
#325 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
2
Forks
105
Avg merge
42m
Merged PRs (30d)
35

Description

- regression added by https://github.com/Azure/sonic-mgmt.msft/commit/05a6979b0e0228c3840d5c6b6cd4545e684c7a88
- with **macsec_card=True** generating invalid minigraph xml( missing declaration tag )
- generating below xml without declaration
`
`
- below is the valid xml
`




`

Proposed fix:
- We need to back port the changes of https://github.com/sonic-net/sonic-mgmt/pull/17530
or
- revert problematic line https://github.com/Azure/sonic-mgmt.msft/blob/202405/ansible/templates/minigraph_link_meta.j2#L3

invalid generated xml without declaration tags
`




MacSecEnabled
True


ARISTA01T3:Ethernet1;cmp214-5:Ethernet5/1





MacSecEnabled
True


ARISTA01T3:Ethernet2;cmp214-5:Ethernet7/1

`

Contributor guide

No contributing guide indexed for this repository

Research direction

Inspect ansible/templates/minigraph_link_meta.j2 at line 3 and compare its output when macsec_card=True with the valid XML shown in the issue. Confirm the generated minigraph contains LinkMetadataDeclaration and Link wrappers around each LinkMetadata entry; completion means the output is valid XML with the declaration tags present.

Written by the indexing model from the issue text.

Assessment

Domain
networking
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.