Azure / Azure/postgresql

Support `psql` as part of the server host

Open
#48 2 comments 2 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
25
Forks
22
PR merge metrics
No merged PRs in 30d

Description

According to the [CAF (Cloud Adoption Framework)](https://learn.microsoft.com/en-us/azure/cloud-adoption-framework/ready/azure-best-practices/resource-abbreviations) the official abbreviation for a PostgreSQL database is `psql`.

But the current implementation blindly replaces [`'psql'` with `''`](https://github.com/Azure/postgresql/blob/1d47d25bbb9375f1192ff806291f807dd2ce9e92/src/Utils/ActionInputs.ts#L27C1-L28C1), which breaks the ability to use this action with such a named DB.

**Input**:

```yml
- uses: azure/postgresql@v1
with:
connection-string: host=caf-named-db-psql.postgres.database.azure.com ...
```

**Output**:

```
psql: error: could not translate host name "caf-named-db-.postgres.database.azure.com" to address: Name or service not known
Error: Error occurred while running action:
Error: The process '/usr/bin/psql' failed with exit code 2
```

**Personal workaround**:

The code currently not only replaces `'psql'` with `''`, it also (as a second step) replaces `'"'` with `''`. So a functional workaround that I use is adding a rouge `"` like this:

```yml
- uses: azure/postgresql@v1
with:
connection-string: host=caf-named-db-p"sql.postgres.database.azure.com ...
```

But this is far from ideal 😂

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.