Azure / Azure/orkestra

Benign error messages being logged on deletion despite a successful reversal (and delete ops)

Open
#372 1 comment 0 reactions 1 assignee Claimed by @jonathan-innis View on GitHub
bug
Dominant language
Go
Stars
112
Forks
21
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
Benign errors being fired and logged on successful delete of applicationgroup

```log
{"level":"error","ts":1630082352.002124,"logger":"controllers.ApplicationGroup","msg":"failed to patch the application group status","appgroup":"webserver","error":"applicationgroups.orkestra.azure.microsoft.com \"webserver\" not found","stacktrace":"github.com/Azure/Orkestra/controllers.(*ApplicationGroupReconciler).Reconcile.func1\n\t/Users/nitishm/github/Azure/orkestra/controllers/appgroup_controller.go:97\ngithub.com/Azure/Orkestra/controllers.(*ApplicationGroupReconciler).Reconcile\n\t/Users/nitishm/github/Azure/orkestra/controllers/appgroup_controller.go:113\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/Users/nitishm/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.8.3/pkg/internal/controller/controller.go:298\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/Users/nitishm/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.8.3/pkg/internal/controller/controller.go:253\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func1.2\n\t/Users/nitishm/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.8.3/pkg/internal/controller/controller.go:216\nk8s.io/apimachinery/pkg/util/wait.JitterUntilWithContext.func1\n\t/Users/nitishm/go/pkg/mod/k8s.io/apimachinery@v0.20.2/pkg/util/wait/wait.go:185\nk8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1\n\t/Users/nitishm/go/pkg/mod/k8s.io/apimachinery@v0.20.2/pkg/util/wait/wait.go:155\nk8s.io/apimachinery/pkg/util/wait.BackoffUntil\n\t/Users/nitishm/go/pkg/mod/k8s.io/apimachinery@v0.20.2/pkg/util/wait/wait.go:156\nk8s.io/apimachinery/pkg/util/wait.JitterUntil\n\t/Users/nitishm/go/pkg/mod/k8s.io/apimachinery@v0.20.2/pkg/util/wait/wait.go:133\nk8s.io/apimachinery/pkg/util/wait.JitterUntilWithContext\n\t/Users/nitishm/go/pkg/mod/k8s.io/apimachinery@v0.20.2/pkg/util/wait/wait.go:185\nk8s.io/apimachinery/pkg/util/wait.UntilWithContext\n\t/Users/nitishm/go/pkg/mod/k8s.io/apimachinery@v0.20.2/pkg/util/wait/wait.go:99"}
```

**To Reproduce**
Steps to reproduce the behavior:
1. Create ApplicationGroup - example/simple/bookinfo and wait for it to complete reconciling
2. Delete the applicationgroup and wait for the reversal to complete successfully

**Expected behavior**
Clear logs on successful delete without any error logs

**Environment (please complete the following information):**
- Kubernetes Version [e.g. 1.21.0]
- Kubernetes Distro [e.g. AKS, GKE, etc.]
- Orkestra Version Tag
- Helm Version

**Additional context**
Add any other context about the problem here.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.