Azure / Azure/orkestra

AppGroup Re-Create causes some Workflows to Hang

Open
#275 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
Go
Stars
112
Forks
21
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
On re-create, ApplicationGroups will delete their helmReleases to cleanup the namespace. If there is a forward workflow that is also running while this happens, it is possible that a race condition surfaces where the forward workflow upgrades a HelmRelease that is subsequently deleted by the previous reverse workflow.

**To Reproduce**
1. Create an ApplicationGroup based on bookinfo (or anything else)
2. Delete the ApplicationGroup
3. Create the ApplicationGroup immediately after deleting

**Expected behavior**
HelmReleases should be conisdered separate on different workflows and sectioned off from other HelmReleases. Perhaps we give a unique identifier to HelmReleases from previous workflows to keep this overlapping from happening?

Contributor guide

Open the contributing guide

Research direction

Start by tracing ApplicationGroup deletion and recreation alongside the HelmRelease cleanup and upgrade paths. Reproduce the race with the bookinfo ApplicationGroup and overlapping workflows. Done means HelmReleases from concurrent or successive workflows cannot delete or upgrade one another, and the workflow completes without hanging.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, helm, kubernetes
Domain
devops, distributed-systems, release
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.