Azure / Azure/orkestra

Pass executor template configuration through the ApplicationGroup spec

Open
#188 3 comments 0 reactions 1 assignee Claimed by @nitishm View on GitHub
chore size : M
Dominant language
Go
Stars
112
Forks
21
PR merge metrics
No merged PRs in 30d

Description

Currently the default executor is hardcoded,

```go
func defaultExecutor(timeout time.Duration) v1alpha12.Template {
executorArgs := []string{"--spec", "{{inputs.parameters.helmrelease}}", "--timeout", timeout.String()}
return v1alpha12.Template{
Name: helmReleaseExecutor,
ServiceAccountName: workflowServiceAccountName(),
Inputs: v1alpha12.Inputs{
Parameters: []v1alpha12.Parameter{
{
Name: "helmrelease",
},
},
},
Executor: &v1alpha12.ExecutorConfig{
ServiceAccountName: workflowServiceAccountName(),
},
Outputs: v1alpha12.Outputs{},
Container: &corev1.Container{
Name: "executor",
Image: "azureorkestra/executor:v0.1.0",
Args: executorArgs,
},
}
}
```

Rather than using a static template we should pass the container configuration through the `ApplicationGroup` spec.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.