Azure / Azure/notation-azure-kv

Multiple wrong commands in setup.sh

Open
#53 3 comments 0 reactions 2 assignees Claimed by @yizha1 View on GitHub
bug
Dominant language
C#
Stars
17
Forks
31
PR merge metrics
No merged PRs in 30d

Description

Trying to reverse engineer the script setup.sh to understand how to use this plugin, I discovered mutiple commands wrong.

* `notation key remove` should be `notation key delete`
* `notation cert remove` should be `notation cert delete`

* `notation key add --name $keyName --plugin azure-kv --id $keyID --kms` should be `notation key add --plugin azure-kv --id $keyID $keyName`

* `notation cert add --name $keyName --plugin azure-kv --id $keyID --kms` is not usable at all... The cert should be a local PEM imported.
Could eventualy be :
```
az keyvault certificate download --encoding PEM --name $keyName --vault-name $keyVaultName --file tmpcert.pem
notation cert add --store test --type signingAuthority tmpcert.pem
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.