Azure / Azure/ng-deploy-azure

Deploy Failing in Continuous Integration Mode

Open
#94 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
79
Forks
47
PR merge metrics
No merged PRs in 30d

Description

**Describe the bug**
ng-deploy working fine in interactive mode but when i try to deploy in CI mode its failing with

> Get Token request returned http error: 400 and server response: {"error":"invalid_request","error_description":"AADSTS900023: Specified tenant identifier ''**************************-***-**''' is neither a valid DNS name, nor a valid external domain

**To Reproduce**
Steps to reproduce the behavior:

my packages are
```

"dependencies": {
"@angular/animations": "8.2.12",
"@angular/cdk": "~8.2.3",
"@angular/common": "8.2.12",
"@angular/compiler": "8.2.12",
"@angular/core": "8.2.12",
"@angular/forms": "8.2.12",
"@angular/material": "^8.2.3",
"@angular/platform-browser": "8.2.12",
"@angular/platform-browser-dynamic": "8.2.12",
"@angular/platform-server": "8.2.12",
"@angular/router": "8.2.12",
"@azure/ng-deploy": "^0.2.3"
}
```

and create Service Principal using the Azure CLI, will give you something like this

> {
> "appId": "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx",
> "displayName": "",
> "name": "http://",
> "password": "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx",
> "tenant": "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx"
> }
>

and I'm able to login with

> az login --service-principal -u $CLIENT_ID -p $CLIENT_SECRET --tenant $TENANT_ID

But when trying to deploy with ng-deploy with CI = 1 (ng run myapp:deploy)

> CI mode detected
> Checking for configuration...
> Using CLIENT_ID='xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx'
> Using CLIENT_SECRET='~***~**********************-***-**'
> Using TENANT_ID='xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx'
> Using AZURE_SUBSCRIPTION_ID='xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx'
> Configuration OK

> Get Token request returned http error: 400 and server response: {"error":"invalid_request","error_description":"AADSTS900023: Specified tenant identifier ''xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx'' is neither a valid DNS name, nor a valid external domain
>

**Expected behavior**

should deploy to CDN same as interactive mode

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.