Azure / Azure/k8s-deploy

Fix annotations links using github.com even for GHES

Open
#201 4 comments 0 reactions 0 assignees Claimed by @ejaifeobuks View on GitHub
backlog
Dominant language
TypeScript
Stars
288
Forks
125
Avg merge
5d 16h
Merged PRs (30d)
4

Description

There are few locations were github.com is hardcoded, making it incompatible with github enterprise servers that are hosted on other domains.
From what I understood from these code lines, they are only cosmetic (sent as annotations in deployments).

https://github.com/Azure/k8s-deploy/blob/507f2d4fc713cdc92f96880e350464687ce2e960/src/utilities/workflowAnnotationUtils.ts#L24
https://github.com/Azure/k8s-deploy/blob/ca8d2604acf262265b6640fc4de4e060effbb555/src/utilities/githubUtils.ts#L47

There is `GITHUB_SERVER_URL` env var and [some others](https://docs.github.com/en/enterprise-server@2.22/actions/learn-github-actions/environment-variables) to get the server domain.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.