Azure / Azure/iotedge

iotedge check "container-engine-logrotate" should not require rotate options when driver is "local"

Open
#6,754 3 comments 0 reactions 0 assignees View on GitHub
customer-reported iotedge no-issue-activity
Dominant language
C#
Stars
1.5k
Forks
473
Avg merge
2d 17h
Merged PRs (30d)
7

Description

## Expected Behavior
`iotedge check` should not warn me that the "Container engine is not configured to rotate module logs..." when I use [Docker's local log driver](https://docs.docker.com/config/containers/logging/local/). The container engine _is_ configured to rotate module logs; the local driver provides default values for `max-size` and `max-file` if the user does not explicitly give them.

## Current Behavior
IoT Edge [docs](https://learn.microsoft.com/en-us/azure/iot-edge/how-to-provision-single-device-linux-symmetric?view=iotedge-1.4&tabs=azure-portal%2Cubuntu) recommend that I use Docker's local log driver. When I follow that recommendation by creating daemon.json like this:

```json
{
"log-driver": "local"
}
```

...then the `iotedge` tool's "container-engine-logrotate" check emits a warning because I didn't explicitly add a `log-opts` object with `max-file` and `max-size` values to daemon.json.

### Runtime Versions
* aziot-edged [run `iotedge version`]: 1.4
* Edge Agent [image tag (e.g. 1.0.0)]: 1.4
* Edge Hub [image tag (e.g. 1.0.0)]: 1.4
* Docker/Moby [run `docker version`]: any version that supports the local log driver

## Additional Information
@drwill-ms originally filed this as doc issue MicrosoftDocs/azure-docs#100762. I'm filing this issue because I believe the fix should be made in `iotedge check` instead.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.