Azure / Azure/fleet

[BUG] [FEATURE] AppliedWork resource object should not be deleted until the propagated resources are cleaned-up in member clusters

Open
#1,036 2 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Go
Stars
226
Forks
44
Avg merge
11h 7m
Merged PRs (30d)
5

Description

### **Describe the bug**
A clear and concise description of what the bug is.
AppliedWork CR does not have any clean-up finalizers in member clusters. There is no error propagated back to hub, if the `kube-system:garbage-collector` fails to delete the orphan resources i.e the resources propagated to member clusters, leaving those orphan leaking resource in member clusters.

I see there is a TODO here that says 'allow orphan resource', was wondering if this is a bug or some feature being worked up
https://github.com/Azure/fleet/blob/51ceeb3466bb5cf22dc561abb2570d740440929b/pkg/controllers/workv1alpha1/apply_controller.go#L225

### **Environment**
Please provide the following:
- Hub cluster details: hub-agent v0.8.5
- Member cluster details: member-agent v0.8.5

### **To Reproduce**
Steps to reproduce the behavior:
- Create a CustomResourcePlacement in hub cluster to propagate namspace to one of the member clusters
- Wait until the namespace is propagated
- Write a ValidatingWebhook to disallow the deletion of namespace in member cluster, if there are resources in the namespace
- See that kube-system:garbage-collector does not delete the namespace but deletes all the associated resources created by fleet agent in member and hub clusters.
- There is no status of error propagated back to hub, leaving the orphan resources in member clusters.
### **Expected behavior**
A clear and concise description of what you expected to happen.
- Expectation is that the parent resource i.e Applied should not be deleted until the propagated resources are cleaned-up.
- If there is error in cleaning up child resources, the error should be propagated to CustomResourcePlacement CR appropriately.
### **Screenshots**
If applicable, add screenshots to help explain your problem.

Image

Image

Image

### **Additional context**
Add any other context about the problem here.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.