Azure / Azure/durabletask

AzureStorageOrchestrationService throws the wrong exception type

Open
#831 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
C#
Stars
1.7k
Forks
335
Avg merge
2d 23h
Merged PRs (30d)
6

Description

Hey,

IOrchestrationServiceClient.CreateTaskOrchestrationAsync [documentation](https://github.com/Azure/durabletask/blob/d89ca586ff9ab4bb7443562beeb3f501783130f7/src/DurableTask.Core/IOrchestrationServiceClient.cs#L40) states that the exception type needed to be thrown in a create scenario where there is already an existing orchestration with the same id and has a status specified in dedupeStatuses is 'OrchestrationAlreadyExistsException'.
Also, it will help identify the flow better.
In reality, the [code](https://github.com/Azure/durabletask/blob/7a5d1774135214ff30c74a236f1670425715e059/src/DurableTask.AzureStorage/AzureStorageOrchestrationService.cs#L1570) throws InvalidOperationException.

Can you please align this behavior? thank you.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.