Azure / Azure/durabletask

Infrastructure exceptions in TaskActivityExceptions are not properly serialized

Open
#508 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C#
Stars
1.7k
Forks
335
Avg merge
2d 23h
Merged PRs (30d)
6

Description

As pointed out by @robs in [this Durable Functions issue](https://github.com/Azure/azure-functions-durable-extension/issues/697), this [catch block](https://github.com/Azure/durabletask/blob/main/src/DurableTask.Core/TaskActivityDispatcher.cs#L172) sets the details to be more of an error message rather than a serialized exception, resulting in a `TaskFailedExceptionDeserializationException` in the orchestrator function. This is very miselading.

Fixing this to properly serialize the original exception thrown by the infrastructure could debatably be considered a breaking change, as customers may be taking a dependency on `TaskFailedExceptionDeserializationException` being thrown, but it feels more like a bug fix.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.