Azure / Azure/data-api-builder

Evaluate if refactor of CreateMutation.Build() to accept RuntimeConfig object is beneficial

Open
#2,132 2 comments 0 reactions 1 assignee Claimed by @severussundar View on GitHub
Multiple mutations refactor
Dominant language
C#
Stars
1.5k
Forks
370
Avg merge
3d 17h
Merged PRs (30d)
8

Description

PR https://github.com/Azure/data-api-builder/pull/2116 introduces a new parameter called `isMultipleCreateOperationEnabled` to `CreateMutationBuilder.Build()` method.

`isMultipleCreateOperationEnabled` can be computed using `RuntimeConfig.IsMultipleCreateOperationEnabled()`.
`CreateMutationBuilder.Build()` method accepts another parameter called `entities` of type `RuntimeEntities`. `entities` originates from `RuntimeConfig.RuntimeEntities`

Evaluate if it is beneficial to refactor `CreateMutationBuilder.Build()` method to accept `RuntimeConfig` object instead of two parameters separately.

Original discussion: https://github.com/Azure/data-api-builder/pull/2116#discussion_r1536631102

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.