Azure / Azure/data-api-builder
Assess refactor of code hydrating DbType for MsSql
Open
refactor
- Dominant language
- C#
- Stars
- 1.5k
- Forks
- 370
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 8
Description
The only additional step that `MsSqlMetadataProvider.PopulateColumnDefinitionWithHasDefaultAndDbType` performs different than its base class's definition is:
https://github.com/Azure/data-api-builder/blob/0829d859301e9611c501b562cfc85e60e20b485a/src/Core/Services/MetadataProviders/MsSqlMetadataProvider.cs#L109
and same for MsSqlMetadataProvider.FillSchemaForStoredProcedureAsync:
https://github.com/Azure/data-api-builder/blob/0829d859301e9611c501b562cfc85e60e20b485a/src/Core/Services/MetadataProviders/MsSqlMetadataProvider.cs#L171
Need to assess this code duplication later and refactor accordingly if required.
Contributor guide
Assessment
This issue has not been assessed yet.