Samples only set once
- Dominant language
- Python
- Stars
- 938
- Forks
- 162
- PR merge metrics
- No merged PRs in 30d
Description
Branch: develop/1.1
https://github.com/Azure/counterfit/blob/ff4f3c7c593856830e5a9b07bd1627f71fbcfc61/counterfit/core/attacks.py#L51
Getting samples happens in `cfattack.__init__`. It should happen in `cfattack.prepare_attack` which is called before the attack is run in `core.run_attack`.
```python
# Get the samples.
self.samples = target.get_samples(
self.options.cf_options["sample_index"]["current"]
)
```
Contributor guide
No contributing guide indexed for this repository
Research direction
Start in counterfit/core/attacks.py at cfattack.__init__ and inspect prepare_attack, then trace the call from core.run_attack. Confirm samples are obtained during attack preparation rather than only during initialization, and verify the attack flow uses the current sample index.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cli, machine-learning, security
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 52/100