Azure / Azure/bicep

decompile does not recognize dependencies from a loop

Open
#6,074 0 comments 1 reaction 0 assignees View on GitHub
story: decompiler
Dominant language
Bicep
Stars
3.6k
Forks
830
Avg merge
1d 21m
Merged PRs (30d)
79

Description

**Bicep version**
Bicep CLI version 0.4.1272 (a69022dd2c)

**Describe the bug**
When decompiling resource loops, the dependencies are created with resourceId rather than the required resource reference. Might be the same as #5622

**To Reproduce**
Decompile the following:

```json
{
"$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentTemplate.json#",
"contentVersion": "1.0.0.0",
"variables": {
"numberOfAccounts": 2,
"blobsPerAccount": 3,
"saprefix": "[uniqueString(resourceGroup().id)]"
},
"resources": [
{
"type": "Microsoft.Storage/storageAccounts",
"apiVersion": "2021-08-01",
"name": "[format('{0}{1}', variables('saprefix'), copyIndex())]",
"location": "[resourceGroup().location]",
"sku": {
"name": "Standard_LRS"
},
"kind": "StorageV2",
"copy": {
"name": "sa",
"count": "[variables('numberOfAccounts')]"
}
},

{
"type": "Microsoft.Storage/storageAccounts/blobServices",
"apiVersion": "2021-08-01",
"name": "[format('{0}{1}/default', variables('saprefix'), copyIndex())]",
"copy": {
"name": "blobServices",
"count": "[variables('numberOfAccounts')]"
},
"dependsOn": [
"[resourceId('Microsoft.Storage/storageAccounts', format('{0}{1}', variables('saprefix'), copyIndex()))]"
]
},
{
"type": "Microsoft.Storage/storageAccounts/blobServices/containers",
"apiVersion": "2021-08-01",
"name": "[format('{0}{1}/{2}/{3}{4}', variables('saprefix'), mod(copyIndex(), variables('numberOfAccounts')), 'default', 'container', mod(copyIndex(), variables('blobsPerAccount')))]",
"copy": {
"name": "blobs",
"count": "[mul(variables('numberOfAccounts'), variables('blobsPerAccount'))]"
},
"dependsOn": [
"[resourceId('Microsoft.Storage/storageAccounts', format('{0}{1}', variables('saprefix'), mod(copyIndex(), variables('numberOfAccounts'))))]",
"[resourceId('Microsoft.Storage/storageAccounts/blobServices', format('{0}{1}', variables('saprefix'), mod(copyIndex(), variables('numberOfAccounts'))), 'default')]"
]
}
]
}
```

Decompiled code:

```bicep
var numberOfAccounts = 2
var blobsPerAccount = 3
var saprefix_var = uniqueString(resourceGroup().id)

resource saprefix 'Microsoft.Storage/storageAccounts@2021-08-01' = [for i in range(0, numberOfAccounts): {
name: '${saprefix_var}${i}'
location: resourceGroup().location
sku: {
name: 'Standard_LRS'
}
kind: 'StorageV2'
}]

resource saprefix_default 'Microsoft.Storage/storageAccounts/blobServices@2021-08-01' = [for i in range(0, numberOfAccounts): {
name: '${saprefix_var}${i}/default'
dependsOn: [
resourceId('Microsoft.Storage/storageAccounts', '${saprefix_var}${i}')
]
}]

resource saprefix_numberOfAccounts_default_container_blobsPerAccount 'Microsoft.Storage/storageAccounts/blobServices/containers@2021-08-01' = [for i in range(0, (numberOfAccounts * blobsPerAccount)): {
name: '${saprefix_var}${(i % numberOfAccounts)}/default/container${(i % blobsPerAccount)}'
dependsOn: [
resourceId('Microsoft.Storage/storageAccounts', '${saprefix_var}${(i % numberOfAccounts)}')
resourceId('Microsoft.Storage/storageAccounts/blobServices', '${saprefix_var}${(i % numberOfAccounts)}', 'default')
]
}]
```

Contributor guide

Open the contributing guide

Research direction

Start by running the decompiler against the ARM JSON reproduction in the issue and compare the generated loop dependencies with the input dependsOn expressions. Done means dependencies for looped resources are emitted as resource references rather than resourceId calls, including both storage account and blob service dependencies.

Written by the indexing model from the issue text.

Assessment

Tech stack
azure
Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.