Azure / Azure/azure_preview_modules

Add timeout to token_res in KeyVault Secret Lookup

Open
#379 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
43
Forks
57
PR merge metrics
No merged PRs in 30d

Description

https://github.com/Azure/azure_preview_modules/blob/2413dafa6f979a2070843b073830901cc1b1d868/lookup_plugins/azure_keyvault_secret.py#L102

Currently using the plugin with environment variable service principal on a local machine that connects to provision virtual appliances. Calls to authenticate with the vault always get stuck here for a long time. Add a reasonable timeout when not used with MSI, e.g.

`token_res = requests.get('http://169.254.169.254/metadata/identity/oauth2/token', params=token_params, headers=token_headers, timeout=10)`

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.