Azure / Azure/azure-webpubsub

Java SDK UT coverage

Open
#60 0 comments 0 reactions 0 assignees View on GitHub
bug-bash-round-1 bug-sdk sdk-java
Dominant language
TypeScript
Stars
147
Forks
96
Avg merge
19h 28m
Merged PRs (30d)
87

Description

https://github.com/Azure/azure-webpubsub/issues/23

- [ ] has unused members
Review [code](https://github.com/Azure/azure-sdk-for-java-pr/blob/webpubsub/sdk/webpubsub/azure-messaging-webpubsub/src/test/java/com/azure/messaging/webpubsub/WebPubSubServiceClientTests.java): members are never used
```java
private WebPubSubAsyncServiceClient asyncClient;
private WebPubSubAsyncGroup asyncGroupClient;
```

- [ ] has no tests for broadcast to a group
Review [code](https://github.com/Azure/azure-sdk-for-java-pr/blob/webpubsub/sdk/webpubsub/azure-messaging-webpubsub/src/test/java/com/azure/messaging/webpubsub/WebPubSubServiceClientTests.java): no tests for broadcast to a group

- [ ] has no tests for sub protocol
Review [code](https://github.com/Azure/azure-sdk-for-java-pr/blob/webpubsub/sdk/webpubsub/azure-messaging-webpubsub/src/test/java/com/azure/messaging/webpubsub/WebPubSubServiceClientTests.java): no tests for sub protocol

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with sdk/webpubsub/azure-messaging-webpubsub/src/test/java/com/azure/messaging/webpubsub/WebPubSubServiceClientTests.java and review the unused async members and existing test coverage. Remove or address the unused members, add coverage for broadcasting to a group and subprotocol handling, then run the Java unit tests to verify the additions.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api, testing
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.