Azure / Azure/azure-webpubsub

[socket.io] Doc issue

Open
#573 0 comments 0 reactions 0 assignees View on GitHub
bugbash-socketio
Dominant language
TypeScript
Stars
147
Forks
96
Avg merge
19h 28m
Merged PRs (30d)
87

Description

In the migration doc, it says some APIs are changed from sync to async, but the code sample here doesn't make much difference:

```js
io.on("connection", async (socket) => { await socket.join("room abc"); });
```

For this particular case it doesn't really matter whether you put await or not.

Contributor guide

No contributing guide indexed for this repository

Research direction

Locate the migration document referenced in the issue and review the socket.join code sample alongside the surrounding explanation of synchronous and asynchronous APIs. Clarify the example so its behavior and the relevance of await are accurate, then verify that the revised wording and sample communicate the intended migration guidance.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
documentation
Issue type
Documentation
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.