Azure / Azure/azure-search-vector-samples

Small bug: model_name instead of deployment_name in AzureOpenAIEmbeddingSkill object creation

Open
#135 7 comments 0 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
910
Forks
377
PR merge metrics
No merged PRs in 30d

Description

When creating the `AzureOpenAIEmbeddingSkill` instance in [azure-search-integrated-vectorization-sample.ipynb](https://github.com/Azure/azure-search-vector-samples/blob/692e2e38d5c29af8790b8280298a1e1f433730d9/demo-python/code/azure-search-integrated-vectorization-sample.ipynb), the `model` variable containing `"text-embedding-ada-002"` model name is used as input for `deployment_id` field, instead of the actual name of the model deployment.

https://github.com/Azure/azure-search-vector-samples/blob/692e2e38d5c29af8790b8280298a1e1f433730d9/demo-python/code/azure-search-integrated-vectorization-sample.ipynb#L301

I think it should be changed to `deployment_id=os.getenv("AZURE_OPENAI_EMBEDDING_DEPLOYED_MODEL")`.

Contributor guide

No contributing guide indexed for this repository

Research direction

Open azure-search-integrated-vectorization-sample.ipynb and inspect the AzureOpenAIEmbeddingSkill creation at the linked line. Verify which environment variable contains the deployed model name, then update the deployment_id value so the notebook uses that deployment rather than the model string. Done means the sample passes the configured deployment name to Azure OpenAI.

Written by the indexing model from the issue text.

Assessment

Tech stack
azure, python
Domain
cloud, search
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.