Azure / Azure/azure-sdk-tools

Our pipelines do not cover sample project compilation.

Open
#9,590 2 comments 0 reactions 0 assignees View on GitHub
Central-EngSys
Dominant language
C#
Stars
135
Forks
260
Avg merge
3d 2h
Merged PRs (30d)
130

Description

Currently in azure-sdk-for-net main the Azure.ResourceManager.Samples.csproj project is broken and won't compile. This was not caught during CI because in the build step we run `dotnet pack` which will ignore the sample csproj, and in the test step we run `dotnet test` which again will ignore the sample csproj.

We should add an extra step somewhere to check if there is a sample project and if there is build it. This is important since our samples in our readme are created from this project and so if it doesn't build we are giving faulty samples to our customers.

Related issue where we found this https://github.com/Azure/autorest.csharp/issues/5214

Contributor guide

Open the contributing guide

Research direction

Start by locating the Azure pipeline steps that run dotnet pack and dotnet test, then inspect how sample projects are identified. Add a CI check that builds Azure.ResourceManager.Samples.csproj when present, and verify that the pipeline catches a sample project compilation failure.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
build-system, ci-cd
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.