Azure / Azure/azure-sdk-tools

Nested internal structs in C99 typedefs show up incorrectly (as a separate struct) in Apiview

Open
#949 0 comments 0 reactions 0 assignees View on GitHub
APIView bug C99
Dominant language
C#
Stars
135
Forks
260
Avg merge
1d 22h
Merged PRs (30d)
115

Description

This might be related to: https://github.com/Azure/azure-sdk-tools/issues/950

For example, see https://apiview.dev/Assemblies/Review/2339253c7f1343dabf7d78ee5b4496aa

Here's the header file with the typedef:
https://github.com/Azure/azure-sdk-for-c/blob/c12a0107925b004be6f130f986999b33acd1c9fa/sdk/inc/azure/core/az_context.h#L31-L45

Here's what we end up seeing:
![image](https://user-images.githubusercontent.com/6527137/92154079-15a4d980-edda-11ea-8ad0-462e30a9c81d.png)

cc @pakrym, @RickWinter

Contributor guide

Open the contributing guide

Research direction

Compare the C99 typedef in sdk/inc/azure/core/az_context.h at the linked commit with its rendering in the linked APIView review. Trace how the nested internal structs are represented and verify the fix by confirming they no longer appear as separate structs in APIView.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
devtools
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.