Azure / Azure/azure-sdk-tools

Tests with bodies encoded by azure-storage-extensions compression crashing the test-proxy

Open
#8,895 2 comments 0 reactions 1 assignee Claimed by @scbedd View on GitHub
Test-Proxy
Dominant language
C#
Stars
135
Forks
260
Avg merge
3d 1h
Merged PRs (30d)
143

Description

If we don't support a compression algorithm, we currently explode.

[Source teams discussion](https://teams.microsoft.com/l/message/19:59dbfadafb5e41c4890e2cd3d74cc7ba@thread.skype/1724709882845?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=3e17dcb0-4257-4a30-b843-77f47f1d4121&parentMessageId=1724709882845&teamName=Azure%20SDK&channelName=Engineering%20System%20%F0%9F%9B%A0%EF%B8%8F&createdTime=1724709882845)

I need to dig into better fallback.

The lowest effort fix would be to not decompress, treat as bytes, and move on. (no sanitization). However, I think we could take the easier path of taking a dependency on .net version of azure.storage.extensions to get access to the compression algorithm in the test-proxy. That way we don't own implementation but still support it natively.

Going to dig into the test a bit more.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.