Azure / Azure/azure-sdk-tools

LintDiff throws `Error: [Exception] No input files provided` If README `input-file` tag is incorrect.

Open
#8,568 0 comments 0 reactions 1 assignee Claimed by @konrad-jamrozik View on GitHub
Central-EngSys Spec PR Tools specs-model
Dominant language
C#
Stars
135
Forks
260
Avg merge
3d 1h
Merged PRs (30d)
144

Description

Consider this diff:

- file diff: https://github.com/test-repo-billy/azure-rest-api-specs/pull/3376/files#diff-b692dbd279dcb1b41b53b0677eaa91059c19c9e7a088f5c2c117e26bf031fcf7
- comment: https://github.com/test-repo-billy/azure-rest-api-specs/pull/3376/files#r1669120292

![image](https://github.com/Azure/azure-sdk-tools/assets/4429827/e69f1614-cb99-4fd9-9990-ec7749afbff0)

Observe:

`### Tag: package-2024-05`

and

```
```yaml $(tag) == 'package-2023-03'
input-file:
```

The `$(tag)` comparison is wrong, resulting in LintDiff crashing with:

- https://github.com/test-repo-billy/azure-rest-api-specs/pull/3376/checks?check_run_id=27179845422
- https://dev.azure.com/azure-sdk/internal/_build/results?buildId=3942376&view=logs&j=0574a2a6-2d0a-5ec6-40e4-4c6e2f70bea2&t=8a394f49-b3d6-5e61-3c39-1b5f6d2bac9f

![image](https://github.com/Azure/azure-sdk-tools/assets/4429827/73f0c164-3a79-4e37-b78a-438fd65464cb)

Related bug:
- https://github.com/Azure/azure-sdk-tools/issues/8230

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.