Azure / Azure/azure-sdk-tools

Sometimes `Next Steps to Merge` comment fails to update even after `/azp run`

Open
#8,534 0 comments 0 reactions 1 assignee Claimed by @konrad-jamrozik View on GitHub
Central-EngSys Spec PR Tools
Dominant language
C#
Stars
135
Forks
260
Avg merge
1d 22h
Merged PRs (30d)
115

Description

There is a known issue where sometimes the `state` field in the [`openapi-platform` database](https://ms.portal.azure.com/#@microsoft.onmicrosoft.com/resource/subscriptions/8c0e0d10-c2d6-42b8-b1d9-e7132b6f18a3/resourceGroups/openapi-platform-preview/providers/Microsoft.DocumentDb/databaseAccounts/openapi-platform/dataExplorer), in `pullRequests` collection, in `pullRequest.pullRequestComments` has been hashed with `const state: string = sha256(commentBody).toString();` in `renderCommentGroupsFunctions.ts / buildGitHubRequestData` but the updated `commentBody` was never pushed to GitHub.

As such, the code will output following example log:

```
renderNextStepsToMergeCommentGroup: prUrl: https://github.com/Azure/azure-rest-api-specs-pr/pull/18709, RETURN definition upsertCommentGroup. commentGroup.name: NextStepsToMerge, commentGroup.title: 'Next Steps to Merge, result: 'No action taken. commentDataExistsInDb && !commentNeedsUpdate'
```

This can be worked around per instructions in https://aka.ms/pr-tsg

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.